Correct no penetration bcs #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… continuity in halo cells
ali-ramadhan
approved these changes
Mar 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
==========================================
- Coverage 78.33% 77.99% -0.35%
==========================================
Files 119 120 +1
Lines 2373 2413 +40
==========================================
+ Hits 1859 1882 +23
- Misses 514 531 +17
Continue to review full report at Codecov.
|
|
We should tag and release v0.25.0 once this is merged. |
|
do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR amends the implementation of no penetration bcs so that halo points beyond a boundary are calculated correctly; ie, by ensuring that continuity is satisfied in the halo point. This change is necessary to correctly calculate the gradients of velocity fields normal to a boundary, across a boundary.
Resolves #669.
Resolves #668.