-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cell_diffusion_timescale
with zero tracers
#691
Conversation
Might be better to use dispatch here (on the case where the kappa-tuple has length zero) for performance, clarity, and julianism! |
return min(Δz^2 / closure.νv, Δh^2 / closure.νh, | ||
Δz^2 / max_κv, Δh^2 / max_κh) | ||
if length(closure.κ) == 0 | ||
return min(Δz^2 / closure.νv, Δh^2 / closure.νh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could define a function cell_viscous_time_scale
that returns this
I thought of defining min(cell_viscous_timescale, cell_tracer_diffusion_timescale) but then I added tests to make sure |
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
==========================================
+ Coverage 78.05% 78.22% +0.16%
==========================================
Files 120 120
Lines 2447 2466 +19
==========================================
+ Hits 1910 1929 +19
Misses 537 537
Continue to review full report at Codecov.
|
No description provided.