Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "CUDAnative" to "3.0" #717

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the CUDAnative package from ^2.3 to ^2.3, 3.0.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #717 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #717   +/-   ##
=======================================
  Coverage   79.75%   79.75%           
=======================================
  Files         122      122           
  Lines        2489     2489           
=======================================
  Hits         1985     1985           
  Misses        504      504           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6502f07...7c2565f. Read the comment docs.

Copy link
Member

@ali-ramadhan ali-ramadhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but gonna let @glwagner merge this so it doesn't conflict with his other PRs.

@glwagner glwagner merged commit 5cd38ed into master Mar 28, 2020
@glwagner glwagner deleted the compathelper/new_version/2020-03-26-00-11-41-950-53072458 branch March 28, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants