Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generic zeros function work on GPU #720

Merged
merged 3 commits into from
Mar 30, 2020
Merged

Make generic zeros function work on GPU #720

merged 3 commits into from
Mar 30, 2020

Conversation

glwagner
Copy link
Member

Resolves #719.

@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #720 into master will decrease coverage by 3.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage   79.75%   76.58%   -3.17%     
==========================================
  Files         122      122              
  Lines        2489     2422      -67     
==========================================
- Hits         1985     1855     -130     
- Misses        504      567      +63     
Impacted Files Coverage Δ
src/Fields/field.jl 71.42% <100.00%> (-8.34%) ⬇️
src/Coriolis/no_rotation.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Forcing/Forcing.jl 50.00% <0.00%> (-50.00%) ⬇️
src/SurfaceWaves.jl 0.00% <0.00%> (-47.06%) ⬇️
src/AbstractOperations/AbstractOperations.jl 33.33% <0.00%> (-33.34%) ⬇️
src/AbstractOperations/interpolation_utils.jl 63.33% <0.00%> (-33.34%) ⬇️
src/Forcing/model_forcing.jl 66.66% <0.00%> (-33.34%) ⬇️
src/Buoyancy/Buoyancy.jl 61.11% <0.00%> (-23.10%) ⬇️
src/Architectures.jl 66.66% <0.00%> (-22.23%) ⬇️
src/TimeSteppers/TimeSteppers.jl 80.00% <0.00%> (-20.00%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6502f07...e778d2d. Read the comment docs.

@glwagner glwagner merged commit ab6927b into master Mar 30, 2020
@glwagner glwagner deleted the glw/fix-zeros-bug branch March 30, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in zeros function
2 participants