Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autofuzz: Fix logs for bug detector findings #699

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

bertschneider
Copy link
Contributor

@bertschneider bertschneider commented Apr 6, 2023

Autofuzz tries to print caught exceptions, but this fails in case of bug detector findings, as the thrown exceptions are intentionally hard to catch and rethrow themselves if possible. Due to this behavior the following line is potentially loged multiple times: ERROR: Unexpected exception encountered during autofuzz:

In this case the exceptions are also only used to abort the current invocation, logging of the actual findings is done by different means. So it's save to ignore this kind of exceptions.

Fixes #696

Autofuzz tries to print caught exceptions, but this fails in case of bug
detector findings, as the thrown exceptions are intentionally hard to
catch and rethrow themselves if possible.  Due to this behavior the
following line is potentially loged multiple times: `ERROR: Unexpected
exception encountered during autofuzz:`

In this case the exceptions are also only used to abort the current
invocation, logging of the actual findings is done by different
means. So it's save to ignore this kind of exceptions.
Copy link
Contributor

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We played ourselves there :-)

@bertschneider bertschneider requested a review from fmeum April 6, 2023 14:38
@fmeum fmeum merged commit 32e6c84 into main Apr 6, 2023
@fmeum fmeum deleted the FUZZ-658_autofuz_hard_to_catch_exception branch April 6, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

many messages: 'ERROR: Unexpected exception encountered during autofuzz:'
2 participants