fix: remove duplicated outputs from get_aflow_strs_from_iso_and_compo…

…sition
CompRhys · Jul 18, 2024 · ebc1f6e · ebc1f6e
1 parent 3e06cd8
commit ebc1f6e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/aviary/wren/utils.py b/aviary/wren/utils.py
@@ -643,7 +643,7 @@ def get_aflow_strs_from_iso_and_composition(
     anom_ele_to_wyk = dict(zip(anom_amt_dict.keys(), wyckoffs))
     anonymous_formula = RE_ANONYMOUS.sub(RE_SUBST_ONE_PREFIX, anonymous_formula)
 
-    result = []
+    result = set()
     for t in translations:
         wyckoff_part = "_".join(
             RE_WYCKOFF.sub(RE_SUBST_ONE_PREFIX, anom_ele_to_wyk[t[elem]])
@@ -655,9 +655,9 @@ def get_aflow_strs_from_iso_and_composition(
         aflow_str = (
             f"{proto_formula}_{pearson}_{spg}_{canonicalized_wyckoff}:{chemical_system}"
         )
-        result.append(aflow_str)
+        result.add(aflow_str)
 
-    return result
+    return list(result)
 
 
 def count_distinct_wyckoff_letters(aflow_str: str) -> int:

diff --git a/tests/test_wyckoff_ops.py b/tests/test_wyckoff_ops.py
@@ -112,7 +112,7 @@ def test_get_aflow_strs_from_iso_and_composition(
     aflows = get_aflow_strs_from_iso_and_composition(
         isopointal_proto, Composition(composition)
     )
-    assert aflows == expected.split(" ")
+    assert set(aflows) == set(expected.split(" "))
 
     # check the round trip
     assert all(