Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkpoint_model #85

Merged
merged 5 commits into from
Jul 27, 2024
Merged

Fix checkpoint_model #85

merged 5 commits into from
Jul 27, 2024

Conversation

janosh
Copy link
Collaborator

@janosh janosh commented Jul 27, 2024

called in train_model

mypy v1.11.0 caught following issues
aviary/train.py:320: error: Unexpected keyword argument "model" for "checkpoint_model"  [call-arg]
aviary/train.py:320: error: Unexpected keyword argument "epoch" for "checkpoint_model"; did you mean "epochs"?  [call-arg]
aviary/train.py:328: error: Argument "timestamp" to "checkpoint_model" has incompatible type "str | None"; expected "str"  [arg-type]
@janosh janosh added the fix Bug fix label Jul 27, 2024
@janosh janosh merged commit d1bbfe1 into main Jul 27, 2024
3 checks passed
@janosh janosh deleted the fix-checkpoint-model branch July 27, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant