Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove torch scatter dep #88

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Remove torch scatter dep #88

merged 4 commits into from
Sep 10, 2024

Conversation

CompRhys
Copy link
Owner

@CompRhys CompRhys commented Aug 5, 2024

Todo

  • Check if the numerical values are unchanged when loading an existing model.

@janosh janosh added usability Developer experience packaging setup.py, pip/conda related stuff labels Aug 18, 2024
@CompRhys
Copy link
Owner Author

@Abhivega if there's no objections based on this breaking models you're relying on then I will move to merge this in the next few days

@CompRhys CompRhys merged commit 5413c71 into main Sep 10, 2024
3 checks passed
@CompRhys CompRhys deleted the no-torch-scatter branch September 10, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packaging setup.py, pip/conda related stuff usability Developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CompRhys @janosh