-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
function, event, and custom error signatures #130
Open
doublesharp
wants to merge
8
commits into
Consensys:master
Choose a base branch
from
doublesharp:function-custom-error-signatures
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
function, event, and custom error signatures #130
doublesharp
wants to merge
8
commits into
Consensys:master
from
doublesharp:function-custom-error-signatures
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor to show function and custom error sighashes use json formatting for JSON output refactor output handlers add config for errorSigs update readme
split output by filename
Can this get merged in? Custom errors have been available for awhile now and there is no tool that can easily get all the function signatures of them. |
@vquelque wdyt, should we get that into solidity-workspace and rebase the UI changes into master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the functions signature hash tools to also work for custom errors and events.
Custom error sighashes can help with debugging when a client receives a custom error hash but does not have the ABI to decode it.
Reformats output to handle multiple files, show sighash by file. Conflicts per file as well.
Use
plaintext
andjson
doc types.Doesn't open a new document when there are no signatures to report.