Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logic for adding "plugins" #16

Open
earrietadev opened this issue Jan 29, 2024 · 4 comments
Open

Allow logic for adding "plugins" #16

earrietadev opened this issue Jan 29, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers ODHack

Comments

@earrietadev
Copy link
Contributor

earrietadev commented Jan 29, 2024

Just like the "modules" logic, let's add the possibility for others to extend the functionality of this kit by integrating "plugins".

Let's make an example of what a plugin could be by adding a SEP10 plugin to the repo

@earrietadev earrietadev added the good first issue Good for newcomers label Jun 12, 2024
@martinvibes
Copy link

is this still open for contribution

@BernalHQ
Copy link

BernalHQ commented Jun 20, 2024

Hi @earrietadev , my name is Bernal, I currently work as a backend software developer, but I also like to do some Frontend. I have 4 years of experience in software development. I would like to make my first one with this issue and contribute to the project and allow me to learn more about the project. I believe I have enough experience to complete the issue and contribute to the project.

@BernalHQ
Copy link

Thank you @earrietadev

@BernalHQ
Copy link

Hello @earrietadev , I have a question. I was researching about the Stellar ecosystem and what SEP-10s are, and I now have a clearer idea of what this project is about. Regarding the question I have, it's basically to confirm if I understood correctly what I need to do with the issue. What I understood is that I need to create an example of what could be a plugin and how it can extend the functionality of the Stellar-Wallets-Kit, is this correct? So, if this is the case, what I am doing is creating a React project, in which I am installing the Stellar-Wallets-Kit and using the library's exports to create a new module that will be the SEP-10 authentication plugin, all of this outside of the kit. It's not code that is directly added to the Stellar-Wallets-Kit repository. I see it more as code from a third party that will utilize the logic of the kit. I hope I explained it well.

BernalHQ added a commit to BernalHQ/Stellar-Wallets-Kit that referenced this issue Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ODHack
Projects
Status: Ready
Development

No branches or pull requests

4 participants
@BernalHQ @earrietadev @martinvibes and others