Add support for value-of<BackedEnum> #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added Integration tests too, raised an issue with my original work. |
romm
requested changes
Jun 6, 2024
| throw new ClosingBracketMissing($this->symbol()); | ||
| } | ||
|
|
||
| if ($subType instanceof UnionType && count($subType->types()) === 1) { |
There was a problem hiding this comment.
This is not necessary, a union type always has at least 2 elements.
| } | ||
| } | ||
|
|
||
| return new UnionType(...$list); |
There was a problem hiding this comment.
As said earlier, a union type must have at least two elements. We must handle the case where a backed enum has only one case (in which case we can directly return the first element of the list, I guess). This would also require a specific test for it!
| use RuntimeException; | ||
|
|
||
| /** @internal */ | ||
| final class NonArrayOf extends RuntimeException implements InvalidType |
|
Thank you for you work @robchett! This will be available in next release. |
romm
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.