nix-packaging: buildGoPackage no longer produces the $bin output #115
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #114
Not exactly a backward compatible fix for #114, but IMHO it makes sense to not depend on the $bin output at all, since buildGoPackage no longer uses it.
While this breaks the build of morph with nixpkgs-20.03, morph v1.4.0 continues to be buildable with 20.03 packages.
We'll then release morph v1.5.0 and PR it against nixpkgs master, including a remark on missing backward compatibility in the release notes.
@adamtulinius @srhb let me hear your thoughts.