-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental network.buildShell #117
Conversation
If I had more confidence in this, I would entirely drop the possibility of not running nix-build (or anything but eval) from inside a nix-shell, but I'm not quite there yet. In general I feel like inverting control quite a bit more towards the Nix side is the sane thing to do. |
There's an issue with hostnames with special characters because of the way quoting differs in the two methods. Need to figure out a way to fix that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the single comment about the debug print. Also, please give all files a go fmt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added go fmt
.
Basic testing done.
This grants users a medium-to-large escape hatch in that they may define
network.buildShell
to be a shell-compatible drv from which morph can and will executenix-build
.One could, for instance, override the
nix-build
that's on$PATH
by using this. Or just have funny messages displayed whenever a shell is opened.