Don't require using a file to pass nodes to build a derivation with all the system in a grid. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomprince
commented
Feb 7, 2022
Comment on lines
+111
to
+114
| names' = if argsFile != null then | ||
| (builtins.fromJSON argsJSON).names | ||
| else | ||
| names; |
There was a problem hiding this comment.
It would be nice to not need this logic. I filed NixOS/nix#6059 to be able to remove it.
srhb
added
triaged
|
Deferring review here until prior PRs have been rebased and merged, sorry for the wait :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #166.
This adds a new argument to
machine, which is the list of node names to build. This also changesargsFiletoargsJSON, for passing the list of node names from go to nix without needing to write a file to disk.I also added the ability to pass a grid as an attrset, rather than a path to a file with the grid. (I was intending to use this to pass a pre-evaluated nixpkgs in to multiple grids in a single evaluation, to save evaluation time, but it appears that doing so doesn't appear to have a significant impact on evaluation time.