Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(flake): flakify morph #211

Merged
merged 3 commits into from
Feb 28, 2024
Merged

build(flake): flakify morph #211

merged 3 commits into from
Feb 28, 2024

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Feb 28, 2024

Signed-off-by: Christina Sørensen [email protected]

@cafkafk
build(flake): flakify morph
b60c742 
Signed-off-by: Christina Sørensen <[email protected]>
@cafkafk
style: run nix fmt treewide
4a3684b 
Signed-off-by: Christina Sørensen <[email protected]>
@cafkafk
build(git): ignore treewide nix fmt
9c70784 
Signed-off-by: Christina Sørensen <[email protected]>
@cafkafk cafkafk marked this pull request as ready for review February 28, 2024 07:52
@cafkafk
Copy link
Member Author

cafkafk commented Feb 28, 2024

Avoid rebase/squash merging (because it will ruin the hash of 4a3684b, breaking 9c70784), or notify me that you'd prefer to rebase/squash, and I'll follow up with a PR doing 9c70784 after this merges, so the commit hash is locked in through this PR.

@cafkafk
Copy link
Member Author

cafkafk commented Feb 28, 2024

Found this PR which seems to have died #153, should likely be closed if this merges.

srhb
srhb approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I didn't know about the ignored revs feature, that's very handy.

@srhb srhb merged commit d5bf048 into master Feb 28, 2024
2 checks passed
@srhb srhb mentioned this pull request Feb 28, 2024
Closed
@cafkafk cafkafk deleted the flakify-morph branch February 28, 2024 08:20
@cafkafk
Copy link
Member Author

cafkafk commented Feb 28, 2024

Nice. I didn't know about the ignored revs feature, that's very handy.

Nixpkgs also has one if you wanna see what kinda stuff they use it for: https://github.com/NixOS/nixpkgs/blob/master/.git-blame-ignore-revs :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cafkafk @srhb