Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore the defaults entry in the network file #214

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

cleverca22
Copy link
Contributor

No description provided.

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you elaborate a bit on what the motivation behind this PR is, and what it aims to accomplish? It makes it much easier to review :)

@cleverca22
Copy link
Contributor Author

nixops had a feature where you could specify a defaults entry in the network file, basically:

{
  defaults = {
    documentation.enable = false;
  };
  host1 = ...;
  host2 = ...;
}

and then nixos would merge defaults into every host

morph still has a blacklist to exclude defaults as a valid hostname, but doesnt actually merge it into each host, so it just silently discards this

the PR restores the functionality, so defaults works again

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

(ping @srhb for second opinion before merge)

@srhb
Copy link
Contributor

srhb commented Jul 17, 2024

agreed!

@srhb srhb merged commit 107f20a into DBCDK:master Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants