-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the project to using Go modules #53
Conversation
Please squash & merge this PR, the commits are not master-quality. I can rebase the commits as well, but I'd rather have you write out the commit message. Thanks! |
Hi @kalbasit, Thanks a lot for this, I appreciate you doing this work. It's clear that go modules is the future, but (and I have a feeling that I also speak on behalf of @johanot when I say this) I know nothing at all about go modules, so we'll have to go read up on it before playing with this PR properly. I'll try to get a proper look of this during this week! |
@adamtulinius absolutely! My main motivation for doing this work is to play with I am available if you have any questions. Thank you! |
It sounds like go modules isn't going to be finalized before go 1.13, slated for release in august, so isn't it a bit premature to jump on the bandwagon already, especially considering nixos 19.03 only ships go 1.11, and not 1.12, which contain changes to how modules work? |
@adamtulinius if your target is stable, then it might be too premature to merge this now. As I said previously, I was motivated by this change to make sure that |
Yeah, we'll probably just hit the snooze button on this PR until we're closer to NixOS 19.09. Thanks for understanding :-) |
I think that even though Go 1.13 isn't on Nix yet, it's safe to merge this PR. Most Go packages you see now will almost certainly have |
Maybe nowish :) |
I think it's time, yes. Should I rebase @adamtulinius ? |
That would be much appreciated, @kalbasit :) |
I incorporated your changes in #148 and also dropped a bunch of our custom shell logic. Thank you! |
This pull request proposes migrating the morph project to using Go Modules and builds the project using buildGoModule.