Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the project to using Go modules #53

Closed
wants to merge 6 commits into from

Conversation

kalbasit
Copy link
Contributor

@kalbasit kalbasit commented Mar 21, 2019

This pull request proposes migrating the morph project to using Go Modules and builds the project using buildGoModule.

@kalbasit kalbasit marked this pull request as ready for review March 22, 2019 03:48
@kalbasit
Copy link
Contributor Author

Please squash & merge this PR, the commits are not master-quality. I can rebase the commits as well, but I'd rather have you write out the commit message. Thanks!

@adamtulinius
Copy link
Contributor

Hi @kalbasit,

Thanks a lot for this, I appreciate you doing this work.

It's clear that go modules is the future, but (and I have a feeling that I also speak on behalf of @johanot when I say this) I know nothing at all about go modules, so we'll have to go read up on it before playing with this PR properly. I'll try to get a proper look of this during this week!

@kalbasit
Copy link
Contributor Author

kalbasit commented Mar 26, 2019

@adamtulinius absolutely! My main motivation for doing this work is to play with buildGoModule outside of nixpkgs. I wanted to make sure that it works in similarly to buildGoPackage with the added benefit of Go modules. Please review this PR at your discretion. Also, feel free to push to it any changes that you see fit.

I am available if you have any questions.

Thank you!

@adamtulinius
Copy link
Contributor

It sounds like go modules isn't going to be finalized before go 1.13, slated for release in august, so isn't it a bit premature to jump on the bandwagon already, especially considering nixos 19.03 only ships go 1.11, and not 1.12, which contain changes to how modules work?

@kalbasit
Copy link
Contributor Author

kalbasit commented May 9, 2019

@adamtulinius if your target is stable, then it might be too premature to merge this now. As I said previously, I was motivated by this change to make sure that buildGoModule works well outside of nixpkgs. As you can see in the pull request, I had to hardcode the default nixpkgs which is hardly the best way to do this.

@adamtulinius
Copy link
Contributor

Yeah, we'll probably just hit the snooze button on this PR until we're closer to NixOS 19.09. Thanks for understanding :-)

@johanot johanot added this to the 1.3 milestone Aug 8, 2019
@johanot johanot modified the milestones: 1.3, 1.4 Sep 9, 2019
@diamondburned
Copy link
Contributor

I think that even though Go 1.13 isn't on Nix yet, it's safe to merge this PR. Most Go packages you see now will almost certainly have go.mod.

@grahamc
Copy link

grahamc commented Sep 25, 2020

Maybe nowish :)

@kalbasit
Copy link
Contributor Author

I think it's time, yes. Should I rebase @adamtulinius ?

@adamtulinius
Copy link
Contributor

I think it's time, yes. Should I rebase @adamtulinius ?

That would be much appreciated, @kalbasit :)

@srhb
Copy link
Contributor

srhb commented May 4, 2021

I incorporated your changes in #148 and also dropped a bunch of our custom shell logic. Thank you!

@srhb srhb closed this May 4, 2021
@kalbasit kalbasit deleted the morph_use-build-go-module branch May 4, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants