Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Dockerfile generator script for neurodocker in repo #23

Open
DavidEWarrenPhD opened this issue Sep 29, 2019 · 1 comment
Open

Comments

@DavidEWarrenPhD
Copy link

The included Dockerfile appears to be generated using neurodocker, but a script containing the neurodocker call is not included in this repo. Including the neurodocker generator script would be convenient and would enhance reproducibility. Example at https://github.com/kaczmarj/neurodocker/blob/master/examples/conda_python/generate.sh.

@ericearl
Copy link
Member

@DavidEWarrenPhD Thanks for pointing this out! We should remove most of that from the Dockerfile and credit kaczmarj for what came from their neurodocker. What happened was we used kaczmarj's neurodocker from DockerHub for the original first base Dockerfile build and just never deleted all the comments after we had basically rewiritten the whole Dockerfile. Regardless, I will leave this issue open until we make those corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants