Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyses_v2 timecourses overwriting output csv (I believe) #55

Open
iamdamion opened this issue Dec 14, 2021 · 2 comments
Open

Analyses_v2 timecourses overwriting output csv (I believe) #55

iamdamion opened this issue Dec 14, 2021 · 2 comments
Assignees
Labels
bug Something isn't working invalid This doesn't seem right medium priority

Comments

@iamdamion
Copy link
Contributor

I am using the most recent docker image from dcanumn/abcd-hcp-pipeline on docker hub. All seems to be working well in general, but I do see some weird behavior in the timecourses that are generated. This is not a pressing issue at all, but maybe something to look into.

What happened is we have two tasks and rest that we collected. There is onyl one csv per parcellation and the automatically created .csv had far fewer rows than TR in the concatenated rest. (I assumed it was only providing timecourse for the rest scans.) But when I looked into it and compared values on the ptseries to the csv, the values were from our saccade task, which is alphabetically last.

I think that the timecourses might be getting overwritten (and there is no task-specific naming in the file name). Example: Gordon_subcorticals.csv, Gordon.csv, etc.

Not an actual issue as we didn't even expect timecourses or any of those "extra" steps to be included in the pipeline, but I figured I'd let you know this is happening.

@arueter1 arueter1 added bug Something isn't working invalid This doesn't seem right medium priority labels Dec 16, 2021
@arueter1
Copy link
Contributor

Thanks @iamdamion for bringing this up! Something definitely seems off. I've assigned this to a few folks from our team to check out. We'll get back to you as soon as we are able. Thanks for letting us know that this isn't a pressing issue.

@iamdamion
Copy link
Contributor Author

Thanks @iamdamion for bringing this up! Something definitely seems off. I've assigned this to a few folks from our team to check out. We'll get back to you as soon as we are able. Thanks for letting us know that this isn't a pressing issue.

I looked into the logs more. It looks to be happening during the DCAN Bold proc step at the end. And it looks like my idea above is what's happening: It's looping over the tasks, but not including the task name in the csv file paths, so it's just re-writing over and over. Hope that helps a little. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right medium priority
Projects
None yet
Development

No branches or pull requests

5 participants