Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen_c_hdr.pl doesn't understand vectors of unions #12

Open
quietust opened this issue Mar 1, 2020 · 0 comments
Open

codegen_c_hdr.pl doesn't understand vectors of unions #12

quietust opened this issue Mar 1, 2020 · 0 comments

Comments

@quietust
Copy link
Member

quietust commented Mar 1, 2020

This script has never properly supported vectors of unions, such as the "line_subject_target" field in the structure "poetic_form_part" - a recent change to DFHack/df-structures made said union externally-defined, causing the script to emit a TODO comment instead of a syntax error that I could track down and manually fix.

There are a few other things that need to be fixed as well - the size of stl-fstream on 64-bit Windows is now 280 bytes (int64_t[35]), and $vecpad should have been removed entirely since vectors aren't padded in 32-bit or 64-bit Windows (ever since Toady switched to Visual C++ 2015).

@quietust quietust changed the title codegen_c_hdr.pl doesn't understand tagged unions codegen_c_hdr.pl doesn't understand vectors of unions Mar 1, 2020
quietust added a commit to quietust/df_misc that referenced this issue Sep 25, 2020
* Fix size of std::fstream on 64-bit Windows
* Remove "pad" from 32-bit Windows std::vector
* Apply proper name to Destructor vmethods
* Attempt to handle vectors of bitfields, defaulting to int32_t
* Attempt to handle vectors of unions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant