Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unretire-anyone code and make it a module so you can access its naming scheme function #1231

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Crystalwarrior
Copy link
Contributor

now you can get unretire-anyone-style summary of a nemesis

@@ -39,59 +36,80 @@ function addNemesisToUnretireList(advSetUpScreen, nemesis, index)
advSetUpScreen.nemesis_index:insert('#', index)
end

function getHistfigShortSummary(histFig)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rewrite this to make use of dfhack.units.getReadableName(histFig)? Most of the logic is covered by that function.

Which other tool needs access to this function? Can they also use getReadableName?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants