-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiprocessing support for off policy algorithms #439
Conversation
…aselines3 into feat/multienv-off-policy
…t/multienv-off-policy
…aselines3 into feat/multienv-off-policy
Would you have any performance metrics to share vs. single-threaded (agent performance, training time)? I will try to take a look before end of the week :) |
so I've got something qualitative so you get the general idea of the pros/cons of multi envs.
Wall clock time more envs = less sample efficient and faster wall clock time but you can retrieve some sample efficiency by having more gradients steps , in that case you will lose some speed (especially in that experiment with my laptop on cpu only) the slower the env, the bigger the gap with using one env only will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but need to fix the typing thing :)
I reintroduced the |
Description
closes #179
Add support for multiprocessing, only
HerReplayBuffer
not supported (done in #654 ).Motivation and Context
Types of changes
Checklist:
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line