Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min PyTorch version #855

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Bump min PyTorch version #855

merged 1 commit into from
Apr 11, 2022

Conversation

araffin
Copy link
Member

@araffin araffin commented Apr 11, 2022

Description

Bump PyTorch version to be able to use the latest features (will be needed for Stable-Baselines-Team/stable-baselines3-contrib#62 for the covariance matrix), newest version also introduces bug fixes and performance improvements.
In practice, SB3 should still be usable with many PyTorch versions though.

Updated doc to link to Gym official doc website.

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

closes #813

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@araffin araffin requested a review from Miffyli April 11, 2022 16:02
Copy link
Collaborator

@Miffyli Miffyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agree with the point. Thanks for cleaning other URLs as well :). Thankfully PyTorch has been 95% backwards compatible in this regard.

My biggest worry is that saved models might not work as intended (or something small has changed there), but indeed, people can install other PyTorch version for this case.

@araffin araffin merged commit 248f082 into master Apr 11, 2022
@araffin araffin deleted the docs/pytorch-min branch April 11, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Deprecating env checker in favor of Gym's
2 participants