Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address a11y issues #43

Merged
merged 11 commits into from
Jan 29, 2024
Merged

Address a11y issues #43

merged 11 commits into from
Jan 29, 2024

Conversation

will0684
Copy link
Member

This PR contains fixes addressing the issues raised during the a11y review by the IT Accessibility Office.

Issue Solution
a11y - Bad or no reflow on some screen resolutions Reduce length of placeholder strings in the search bar to fit 320x256 resolutions
a11y - Focus order unpredictable Removed flex-row-reverse from container of Reset and Filter buttons in Filter dropdown
a11y - Improperly emulating links Fixed incorrect references in Footer.astro and i18n/ui.ts
a11y - Links must have discernible text Links are now properly labelled and describe their purpose
a11y - New or changed content not being conveyed to Assistive Technologies Added status to indicate when no results are found in a search or filter. Also modified the behaviour of the search text input to behave the same as the button when submitting the form. Previously the page would refresh without actually submitting the search values.
a11y - Page lacks meaningful heading structure Changed footer H3 heading to H2 so that it exists on the same heading level as the "Help improve this tool" H2 in the CallToAction.
a11y - Page section missing lang attribute #1 Added translation strings for alt-text of heading logo
a11y - Page section missing lang attribute #2 Added lang attributes with appropriate values to the language toggle anchors
a11y - Using structural markup in a way that does not represent relationships in the content Added labels to pagination controls for better accessibility

@will0684 will0684 requested a review from a team January 26, 2024 20:44
Copy link
Member

@Fbasham Fbasham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this runs fine. Thank you for inheriting this work and finishing it off.

@will0684 will0684 merged commit a790220 into main Jan 29, 2024
5 checks passed
@will0684 will0684 deleted the a11y-review branch January 29, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants