A11y review 2 #44
Merged
A11y review 2 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
will0684
commented
Feb 1, 2024
will0684
commented
| Issue | Solution |
|---|---|
| Elements on page in illogical order - order of Filter and Search should be the same on mobile as on desktop | Filter now comes before search in mobile view to match desktop order |
| Page section missing lang attribute - Footer GOC logo alt text is in English when user selects French | Added French alt text for Footer logo |
| The skip-link should exist and be focusable | Created skip-links for main content and footer as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.