AB#4215 Add the repository for confirmation code with a delete function #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholas-ly
reviewed
Jun 26, 2024
backend/src/test/java/ca/gov/dtsstn/cdcp/api/data/repository/ConfirmationCodeRepositoryIT.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/ca/gov/dtsstn/cdcp/api/data/repository/ConfirmationCodeRepositoryIT.java
Outdated
Show resolved
Hide resolved
Comment on lines
35
to
37
| assertThat(confirmationCodeRepository.findById("a6ea4925-f813-493e-80ec-a5b90ca28aaa")).isNotEmpty(); | ||
| confirmationCodeRepository.deleteByExpiryDateLessThan(Instant.now()); | ||
| assertThat(confirmationCodeRepository.findById("a6ea4925-f813-493e-80ec-a5b90ca28aaa")).isEmpty(); |
There was a problem hiding this comment.
It may be a good idea to verify that confirmation codes with an expiry date in the future and an expiry date with the current instant are not deleted.
backend/src/main/resources/db-migrations/h2/v0.1-[vendor]-data-init.sql
Outdated
Show resolved
Hide resolved
backend/src/main/java/ca/gov/dtsstn/cdcp/api/data/repository/ConfirmationCodeRepository.java
Outdated
Show resolved
Hide resolved
| @ActiveProfiles("test") | ||
| @Import({ DataSourceConfig.class }) | ||
| @AutoConfigureTestDatabase(replace = Replace.NONE) | ||
| public class ConfirmationCodeRepositoryIT { |
There was a problem hiding this comment.
Something that I don't like about this test is that it relies on data that is in the data-init.sql file.
I know that other tests do the same thing.. I feel that they're also not good tests.
What you should do, instead.. is do a findById(..) and verify that the data doesn't exist, then insert using save(..) and do another findById(..)
There was a problem hiding this comment.
...same idea with the delete method
ESDC-Olivier-Roy
force-pushed
the
add-confirmation-code-repository
branch
from
0af8233
to
e5fa237
Compare
ESDC-Olivier-Roy
force-pushed
the
add-confirmation-code-repository
branch
from
e5fa237
to
96aaa05
Compare
|
Close it for reference. @nicholas-ly will implement it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the repository for confirmation code with a delete function. This will delete all confirmation codes that have their expiry date less than the inserted time.
Related Azure Boards Work Items
AB#4215
Checklist
npm run format:checknpm run lintnpm run typechecknpm run test:unit -- runnpm run test:e2e