Update footer ternary to use publicRuntimeConfig value #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhr-git
approved these changes
Jul 15, 2024
krischarbonneau
added a commit
that referenced
this pull request
Jul 29, 2024
* Update footer ternary to use publicRuntimeConfig value (#705) * Update contact us page to display SIN link (#706) * Add Root Cert Structure to Dockerfile (#707) * Pin base image version in Dockerfile (#709) --------- Co-authored-by: lhr-git <[email protected]>
lhr-git
added a commit
that referenced
this pull request
Aug 21, 2024
* Update footer ternary to use publicRuntimeConfig value (#705) * Update contact us page to display SIN link (#706) * Add Root Cert Structure to Dockerfile (#707) * Pin base image version in Dockerfile (#709) * Update next-auth config to validate SIN and UID (#710) * Swapping from null to a catchall for falsy values (#711) * Swapping from null to a catchall for falsy values (#711) (#712) * Snyk updates bundled together (#714) * Merging dev into staging August 19, 2024 (#715) * Swapping from null to a catchall for falsy values (#711) * Snyk updates bundled together (#714) --------- Co-authored-by: Kris Charbonneau <[email protected]> Co-authored-by: Kris Charbonneau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO-249261
Fixed AB#249261
Changelog
fix:Update ternary in footer component to use publicRuntimeConfig
fix:Add OTEL jaeger dependency to fix local errors
Description of proposed changes:
This PR updates the ternary operation for our footer links to use publicRuntimeConfig given it was returning undefined when swapping between languages when just referring the the environment variable directly. This PR also adds an otel dependency that was causing the terminal to be flooded, at least locally.
What to test for/How to test
ENVIRONMENTis set todevelopmentin your local envnpm run devsrv241on both EN and FR