Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Isolate integration, external tests #1156

Draft
wants to merge 6 commits into
base: v3
Choose a base branch
from

Conversation

DaveSkender
Copy link
Owner

Description

Tests that use live data feeds or represent other forms of integration, such as end use of the package, should be separated from our normal unit test runs to avoid the slippery slope of cross-domain e2e forms. This isolation ensures we do not run these during normal local development unit test runs where speed and true unit test coverage are important.

Separating tests that reflect:

  • use of external data feeds
  • use of library as external package (pure UX tests)

To do

  • add conditional and/or manual run triggers for local development
  • add conditional and/or manual run triggers in CI/CD pipelines
  • move External test portions from unit tests

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have put comments in my code, particularly for hard-to-understand areas
  • I have performed a self-review of my code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings or other code analysis issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@DaveSkender DaveSkender added the on hold On hold / waiting label Jan 28, 2024
@DaveSkender DaveSkender added this to the v3 milestone Jan 28, 2024
@DaveSkender DaveSkender changed the title move external feed test to new project test: Isolate integration, external tests Jan 28, 2024
Copy link

github-actions bot commented Mar 2, 2024

✔️ Tests 728 / 728 - passed in 7.3s
📝 Coverage 94.88%
📏 5471 / 5571 lines covered 🌿 2366 / 2689 branches covered
🔍 click here for more details

✏️ updated for commit 4730fd4

@DaveSkender DaveSkender self-assigned this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold On hold / waiting
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant