Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable marking of violation when in Zen Mode #93

Open
CGMossa opened this issue Nov 5, 2019 · 10 comments
Open

Disable marking of violation when in Zen Mode #93

CGMossa opened this issue Nov 5, 2019 · 10 comments

Comments

@CGMossa
Copy link

CGMossa commented Nov 5, 2019

Great extension and very much appreciated. It would be great, if the markings in editor would be disabled once the editor is in Zen Mode. Or atleast an option to enable/disable markdownlint in zenmode would be very much appreciated.

@DavidAnson
Copy link
Owner

It’ll depend on whether VS Code gives extensions a way to detect Zen Mode. I don’t see anything at https://code.visualstudio.com/api/references/vscode-api, but I’ll check again when I’m not on my phone.

@CGMossa
Copy link
Author

CGMossa commented Mar 15, 2020

Thanks. At this point, I just want to be able to disable it, as it is extremely distracting, but I don't want to disable it via the Extension menu, as then I may never remember to turn in it on again.

@wdscxsj
Copy link

wdscxsj commented Mar 23, 2020

@DavidAnson Is it possible to add a command to toggle it manually? In a quick read of other people's markdown files, one often has no need to do the fixes, and the markings often feel distracting.

@DavidAnson
Copy link
Owner

Yes, that seems straightforward. I expect the command would be a toggle for on/off and would take effect on the current file only and would not be saved. (For anything more permanent, the existing support for “ignore” should be used.)

@wdscxsj
Copy link

wdscxsj commented Mar 23, 2020

Or allow the user to choose whether or not it's a permanent choice? Suppose one has to skim over dozens of markdown files at the same time, and drags them into VSCode, he surely hates to turn it off one by one, or to configure some ignore rules using a project just for immediate viewing.

@DavidAnson
Copy link
Owner

Makes sense, yes. I could make it apply to the entire session. I just do not want it to persist because I worry people will forget they have change this and will be unable to figure out why the extension “isn’t working“. As long as they can close and reopen Code and things work again, that seems good.

@wdscxsj
Copy link

wdscxsj commented Mar 24, 2020

Thanks! I think that'll be very practical.

@DavidAnson
Copy link
Owner

@wdscxsj: The markdownlint.toggleLinting command is available in the 0.35.* release to temporarily turn linting on/off. It can be run directly and/or bound to a keyboard shortcut.

@CGMossa: I looked into detecting Zen mode again and still don't see a way, so I'm leaving this issue open.

@wdscxsj
Copy link

wdscxsj commented Apr 27, 2020

@DavidAnson Confirmed. Thank you very much!

@DavidAnson
Copy link
Owner

Link to open issue in VS Code: microsoft/vscode#114741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants