Skip to content

Commit

Permalink
fix: Revert "chore: Upgrade AGP from 7.6 to 8.0 + Java, Kotlin & Comp… (
Browse files Browse the repository at this point in the history
  • Loading branch information
ManonPolle committed Jun 20, 2023
1 parent a8e28a5 commit 794e307
Show file tree
Hide file tree
Showing 61 changed files with 91 additions and 256 deletions.
4 changes: 0 additions & 4 deletions appbars/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,3 @@ dependencies {
api(project(":menus"))
implementation(AndroidX.compose.ui.tooling)
}

android {
namespace = "com.decathlon.vitamin.compose.appbars"
}
2 changes: 2 additions & 0 deletions appbars/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.appbars" />
4 changes: 0 additions & 4 deletions badges/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,3 @@ dependencies {
api(project(":foundation:foundation"))
implementation(AndroidX.compose.ui.tooling)
}

android {
namespace = "com.decathlon.vitamin.compose.badges"
}
2 changes: 2 additions & 0 deletions badges/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.badges" />
8 changes: 4 additions & 4 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ sonarqube {
conventionalCommits {
scopes = subprojects.map { module -> module.name }.toList()
failureMessage = "Error : The commit message does not meet the Conventional Commit standard\n" +
"An example of a valid message is:\n" +
"feat(buttons): add the small size button\n" +
"Available scopes : ${scopes}\n" +
"More details at: https://www.conventionalcommits.org/en/v1.0.0/#summary"
"An example of a valid message is:\n" +
"feat(buttons): add the small size button\n" +
"Available scopes : ${scopes}\n" +
"More details at: https://www.conventionalcommits.org/en/v1.0.0/#summary"
}

tasks.create<Delete>("clean") {
Expand Down
17 changes: 4 additions & 13 deletions buildSrc/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
kotlin("jvm") version "1.8.21"
kotlin("jvm") version "1.4.31"
`kotlin-dsl`
}

Expand All @@ -11,16 +11,7 @@ repositories {
}

tasks.withType<KotlinCompile>().configureEach {
kotlinOptions {
jvmTarget = JavaVersion.VERSION_17.toString()
apiVersion = "1.6"
}
}

java {
toolchain {
languageVersion.set(JavaLanguageVersion.of(17))
}
kotlinOptions.apiVersion = "1.6"
}

gradlePlugin {
Expand All @@ -32,8 +23,8 @@ gradlePlugin {

dependencies {
implementation(gradleApi())
implementation("com.android.tools.build:gradle:8.0.1")
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.21")
implementation("com.android.tools.build:gradle:7.4.0")
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.7.20")
implementation("com.vanniktech:gradle-maven-publish-plugin:0.18.0")
implementation("app.cash.licensee:licensee-gradle-plugin:1.4.1")
implementation("app.cash.paparazzi:paparazzi-gradle-plugin:1.2.0")
Expand Down
1 change: 0 additions & 1 deletion buildSrc/src/main/kotlin/Libs.kt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ object Libs {
const val vitamin_assets = "com.decathlon.vitamin:foundation-assets:_"

const val compose_ui = "androidx.compose.ui:ui:_"
const val compose_compiler = "androidx.compose.compiler:compiler:_"

const val compose_ui_util = "androidx.compose.ui:ui-util:_"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import com.android.build.api.dsl.LibraryExtension
import org.gradle.api.JavaVersion
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.jvm.toolchain.JavaLanguageVersion
import org.gradle.kotlin.dsl.apply
import org.gradle.kotlin.dsl.configure
import org.gradle.kotlin.dsl.dependencies
Expand All @@ -18,6 +17,7 @@ class VitaminComposeLibraryPlugin : Plugin<Project> {
target.apply(plugin = "app.cash.licensee")
target.configure<app.cash.licensee.LicenseeExtension> {
allow("Apache-2.0")
allow("MIT")
}
target.repositories {
google()
Expand Down Expand Up @@ -52,29 +52,29 @@ internal fun Project.configureAndroid() = this.extensions.getByType(LibraryExten
useSupportLibrary = true
}
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"

}
compileOptions {
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
}
composeOptions {
kotlinCompilerExtensionVersion = Libs.compose_compiler.split(":").last()
kotlinCompilerExtensionVersion = Libs.compose_ui.split(":").last()
}
tasks.withType<KotlinCompile> {
kotlinOptions {
allWarningsAsErrors = true
jvmTarget = JavaVersion.VERSION_17.toString()
jvmTarget = JavaVersion.VERSION_11.toString()
freeCompilerArgs = freeCompilerArgs + listOf(
"-opt-in=kotlin.RequiresOptIn",
"-opt-in=kotlin.RequiresOptIn"
)
}
}

buildFeatures {
compose = true
}

packaging {
packagingOptions {
resources {
excludes += "/META-INF/{AL2.0,LGPL2.1}"
}
Expand Down
4 changes: 0 additions & 4 deletions buttons/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ dependencies {
implementation(AndroidX.compose.ui.tooling)
testImplementation("com.google.testparameterinjector:test-parameter-injector:1.8")
}

android {
namespace = "com.decathlon.vitamin.compose.buttons"
}
2 changes: 2 additions & 0 deletions buttons/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.buttons" />
4 changes: 0 additions & 4 deletions cards/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,3 @@ dependencies {
implementation(AndroidX.compose.ui.tooling)
testImplementation("com.google.testparameterinjector:test-parameter-injector:1.8")
}

android {
namespace = "com.decathlon.vitamin.compose.cards"
}
2 changes: 2 additions & 0 deletions cards/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.cards" />
4 changes: 0 additions & 4 deletions checkboxes/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,3 @@ dependencies {
api(project(":foundation:foundation"))
implementation(AndroidX.compose.ui.tooling)
}

android {
namespace = "com.decathlon.vitamin.compose.checkboxes"
}
5 changes: 5 additions & 0 deletions checkboxes/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.decathlon.vitamin.compose.checkboxes">

</manifest>
4 changes: 0 additions & 4 deletions chips/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,3 @@ dependencies {
testImplementation(project(":foundation:foundation-assets"))
testImplementation("com.google.testparameterinjector:test-parameter-injector:1.8")
}

android {
namespace = "com.decathlon.vitamin.compose.chips"
}
2 changes: 2 additions & 0 deletions chips/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.chips" />
4 changes: 0 additions & 4 deletions dividers/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,3 @@ dependencies {
implementation(AndroidX.compose.ui.tooling)
testImplementation("com.google.testparameterinjector:test-parameter-injector:1.8")
}

android {
namespace = "com.decathlon.vitamin.compose.dividers"
}
2 changes: 2 additions & 0 deletions dividers/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.dividers"/>
4 changes: 0 additions & 4 deletions fabs/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ dependencies {
implementation(AndroidX.compose.ui.tooling)
testImplementation("com.google.testparameterinjector:test-parameter-injector:1.8")
}

android {
namespace = "com.decathlon.vitamin.compose.fabs"
}
2 changes: 2 additions & 0 deletions fabs/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.fabs" />
4 changes: 0 additions & 4 deletions foundation/foundation-assets/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,3 @@ dependencies {
api(AndroidX.compose.ui)
api(AndroidX.compose.material)
}

android {
namespace = "com.decathlon.vitamin.compose.vitaminassets"
}
2 changes: 2 additions & 0 deletions foundation/foundation-assets/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.vitaminassets" />
4 changes: 0 additions & 4 deletions foundation/foundation-icons/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,3 @@ dependencies {
api(AndroidX.compose.ui)
api(AndroidX.compose.material)
}

android {
namespace = "com.decathlon.vitamin.compose.vitaminicons"
}
2 changes: 2 additions & 0 deletions foundation/foundation-icons/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.vitaminicons" />
4 changes: 0 additions & 4 deletions foundation/foundation/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,3 @@ dependencies {
api(AndroidX.compose.ui)
api(AndroidX.compose.material)
}

android {
namespace = "com.decathlon.vitamin.compose.foundation"
}
2 changes: 2 additions & 0 deletions foundation/foundation/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.foundation" />
19 changes: 1 addition & 18 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -32,23 +32,6 @@ org.gradle.daemon=true
org.gradle.jvmargs=-Xmx6g -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8 -XX:+UseParallelGC -XX:MaxMetaspaceSize=1g

android.useAndroidX=true

# buildconfig is not generated at build by default since AGP 8.0 for all project.
# Next step: add this into gradle module that needs the BuildConfig file.
# https://developer.android.com/build/releases/gradle-plugin#default-changes
# https://medium.com/androiddevelopers/5-ways-to-prepare-your-app-build-for-android-studio-flamingo-release-da34616bb946
android.defaults.buildfeatures.buildconfig=true
# nonTransitiveRClass is at true by default since AGP 8.0.
# Next step: Run the migration assistant from Android studio to migrate to Non-Transitive R Classes.
# https://developer.android.com/build/releases/gradle-plugin#default-changes
# https://medium.com/androiddevelopers/5-ways-to-prepare-your-app-build-for-android-studio-flamingo-release-da34616bb946
android.nonTransitiveRClass=false
# AGP 8.0 generates R classes with non-final fields by default.
# Next step: Move to non-final fields.
# https://developer.android.com/build/releases/gradle-plugin#default-changes
android.nonFinalResIds=false

kotlin.incremental=true
# Kotlin code style for this project: "official" or "obsolete":
kotlin.incremental=true
kotlin.code.style=official

2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Fri Jan 20 17:22:46 CET 2023
distributionBase=GRADLE_USER_HOME
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
distributionPath=wrapper/dists
zipStorePath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
4 changes: 0 additions & 4 deletions menus/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,3 @@ dependencies {
api(project(":foundation:foundation"))
implementation(AndroidX.compose.ui.tooling)
}

android {
namespace = "com.decathlon.vitamin.compose.menus"
}
2 changes: 2 additions & 0 deletions menus/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.menus"/>
4 changes: 0 additions & 4 deletions modals/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,3 @@ dependencies {
implementation(project(":buttons"))
implementation(AndroidX.compose.ui.tooling)
}

android {
namespace = "com.decathlon.vitamin.compose.modals"
}
2 changes: 2 additions & 0 deletions modals/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.modals" />
4 changes: 0 additions & 4 deletions prices/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,3 @@ dependencies {
implementation(AndroidX.compose.ui.tooling)
testImplementation("com.google.testparameterinjector:test-parameter-injector:1.8")
}

android {
namespace = "com.decathlon.vitamin.compose.prices"
}
2 changes: 2 additions & 0 deletions prices/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.prices"/>
4 changes: 0 additions & 4 deletions progressbars/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,3 @@ dependencies {
implementation(AndroidX.compose.ui.tooling)
testImplementation("com.google.testparameterinjector:test-parameter-injector:1.8")
}

android {
namespace = "com.decathlon.vitamin.compose.progressbars"
}
2 changes: 2 additions & 0 deletions progressbars/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.progressbars" />
4 changes: 0 additions & 4 deletions quantity-pickers/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ dependencies {
implementation(AndroidX.compose.ui.tooling)
testImplementation("com.google.testparameterinjector:test-parameter-injector:1.8")
}

android {
namespace = "com.decathlon.vitamin.compose.quantity.pickers"
}
2 changes: 2 additions & 0 deletions quantity-pickers/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.quantity.pickers" />
4 changes: 0 additions & 4 deletions radiobuttons/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,3 @@ dependencies {
implementation(AndroidX.compose.ui.tooling)
testImplementation("com.google.testparameterinjector:test-parameter-injector:1.8")
}

android {
namespace = "com.decathlon.vitamin.compose.radiobuttons"
}
2 changes: 2 additions & 0 deletions radiobuttons/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.radiobuttons" />
4 changes: 0 additions & 4 deletions ratings/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,3 @@ dependencies {
implementation(project(":foundation:foundation-icons"))
implementation(AndroidX.compose.ui.tooling)
}

android {
namespace = "com.decathlon.vitamin.compose.ratings"
}
2 changes: 2 additions & 0 deletions ratings/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.decathlon.vitamin.compose.ratings" />
Loading

0 comments on commit 794e307

Please sign in to comment.