Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Badges): fix content color #106

Merged
merged 1 commit into from
Feb 9, 2023
Merged

fix(Badges): fix content color #106

merged 1 commit into from
Feb 9, 2023

Conversation

adrienbusin
Copy link
Contributor

@adrienbusin adrienbusin commented Feb 9, 2023 •
edited by ManonPolle
Loading

Changes description 🧑‍💻

Use good content color for badge text

Context 🤔

Closes #103

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

DARK
Screenshot_1675936915
LIGHT
Screenshot_1675936930

Other info 👋

@adrienbusin adrienbusin requested review from ManonPolle and a team as code owners February 9, 2023 09:51
@lauthieb lauthieb added bug 🐛 Something isn't working run 💨 labels Feb 9, 2023
@adrienbusin adrienbusin requested a review from a team February 9, 2023 10:03
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/24953081-e2a0-4514-ade9-8bd84835a36b/artifact/d8363fcc330c049a/p/fa4940b6d56cf819b9d2d88cee95821e

@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ManonPolle ManonPolle merged commit bd88d29 into Decathlon:main Feb 9, 2023
@ManonPolle ManonPolle mentioned this pull request Feb 9, 2023
Closed
@ManonPolle ManonPolle added this to the 0.3.0 Version milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

@SimonLeclercq SimonLeclercq SimonLeclercq approved these changes

Assignees

@adrienbusin adrienbusin

Labels
bug 🐛 Something isn't working
Projects
Decathlon Design System
Archived in project
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

bug(badge): Wrong text color
5 participants
@adrienbusin @dktbitrise @ManonPolle @SimonLeclercq @lauthieb