New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sample): Remove white background for badges in sample #107

Merged

GerardPaligot merged 1 commit into Decathlon:main from ManonPolle:fix/sample-badge

Feb 16, 2023

Contributor

ManonPolle commented Feb 9, 2023

Changes description 🧑‍💻

Removed fixed color background on Badge Sample screen to be compatible with Dark mode.

Context 🤔

In dark mode, Badge sample screen was white

Checklist ✅

Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
Check compose contract convention. It must follow conventions described here.
Check your code additions will fail neither code linting checks.
I have reviewed the submitted code.
I have tested on a phone device/emulator.
I have tested on a tablet device/emulator.
I have tested on a large screen device/emulator.
If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Other info 👋


          fix(sample): Remove white background for badges in sample

3294c82

ManonPolle added the run 💨 label

ManonPolle requested a review from a team as a code owner

February 9, 2023 15:22

ManonPolle self-assigned this

lauthieb added the bug 🐛 label

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

dktbitrise commented Feb 9, 2023

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/78de410e-6f44-4c1b-86b0-c5eb54e74dec/artifact/5991cf48ebc8b7e2/p/5e1f043fe8ec5b88ac61596dc07ab83a

GerardPaligot approved these changes

View reviewed changes

GerardPaligot merged commit dd3cf77 into Decathlon:main

ManonPolle added this to the 0.3.0 Version milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels