Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quantity-pickers): Add error message label #109

Merged
merged 4 commits into from
Apr 17, 2023
Merged

feat(quantity-pickers): Add error message label #109

merged 4 commits into from
Apr 17, 2023

Conversation

corentin-stamper
Copy link
Contributor

Changes description 🧑‍💻

  • Add error message
  • Add paparazzi tests

Context 🤔

Closes #80
Closes #90

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

@lauthieb lauthieb added enhancement 🚀 New feature or request run 💨 labels Feb 9, 2023
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/ae3d1380-7d65-44ef-af90-b3cde5772527/artifact/3e6be26b050bd4e7/p/c33dc222a16b79b7cf136f747f1b2d98

GerardPaligot
GerardPaligot requested changes Feb 16, 2023
View reviewed changes
...ckers/src/main/java/com/decathlon/vitamin/compose/quantity/pickers/VitaminQuantityPickers.kt Outdated Show resolved Hide resolved
...ckers/src/main/java/com/decathlon/vitamin/compose/quantity/pickers/VitaminQuantityPickers.kt Outdated Show resolved Hide resolved
...ckers/src/main/java/com/decathlon/vitamin/compose/quantity/pickers/VitaminQuantityPickers.kt Outdated Show resolved Hide resolved
...ckers/src/main/java/com/decathlon/vitamin/compose/quantity/pickers/VitaminQuantityPickers.kt Outdated Show resolved Hide resolved
...ckers/src/main/java/com/decathlon/vitamin/compose/quantity/pickers/VitaminQuantityPickers.kt Outdated Show resolved Hide resolved
...ckers/src/main/java/com/decathlon/vitamin/compose/quantity/pickers/VitaminQuantityPickers.kt Outdated Show resolved Hide resolved
...ckers/src/main/java/com/decathlon/vitamin/compose/quantity/pickers/VitaminQuantityPickers.kt Outdated Show resolved Hide resolved
...ckers/src/main/java/com/decathlon/vitamin/compose/quantity/pickers/VitaminQuantityPickers.kt Outdated Show resolved Hide resolved
...ckers/src/main/java/com/decathlon/vitamin/compose/quantity/pickers/VitaminQuantityPickers.kt Outdated Show resolved Hide resolved
@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

@corentin-stamper corentin-stamper requested review from a team February 24, 2023 15:33
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/ff95c805-d522-47fa-9f0b-6589caac0329/artifact/7db2d22575f88c32/p/9e19ba285634ac42de983d3c676bf8cf

@ManonPolle ManonPolle self-requested a review February 24, 2023 16:24
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/15104298-3d6e-41c7-8d78-6a8d4e8c35b4/artifact/9ad5dcadb38501f9/p/4a160b9ab0ee4fb694422f9791d8eeb0

@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/25af83d0-9c61-49bf-8a60-29a40393c5da/artifact/a120e0bab67471eb/p/fb75350da253db8572e39bebd8008ad3

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/b4c5ca87-4e53-449f-9ad3-abe8bfd71bb5/artifact/b9196d2477026061/p/751b4e8869f2c60dd29f403d0d11be55

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/f4f50772-6a14-40ee-91c0-1f89ccb2c273/artifact/857b4f3f1dfe5c71/p/30a612eabfb4dfe46cc46a8afa42bc4b

@lauthieb lauthieb removed the run 💨 label Apr 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/bd550c48-d837-4b89-9d34-32960a5a4ab9/artifact/198aa39868375216/p/f26bb654907fd96b2b891892a38c42fc

@GerardPaligot GerardPaligot merged commit 3515450 into Decathlon:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle left review comments

@GerardPaligot GerardPaligot GerardPaligot approved these changes

Assignees

@corentin-stamper corentin-stamper

Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
5 participants
@corentin-stamper @dktbitrise @GerardPaligot @ManonPolle @lauthieb