Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Add plugin to check conventional commit message format #113

Merged
merged 1 commit into from
Feb 23, 2023
Merged

build: Add plugin to check conventional commit message format #113

merged 1 commit into from
Feb 23, 2023

Conversation

ManonPolle
Copy link
Contributor

Changes description

Add commit checker plugin https://github.com/nicolasfara/conventional-commits
It is based on this https://www.conventionalcommits.org/en/v1.0.0/#summary

Examples of success commit
"feat(buttons): Add a new size for buttons"
"fix: Fix all ui tests"

Example of fail commit
"new: Add my new feature" ( not a conventionnal type )
"feat(button): Add a new size for buttons" ( button instead of buttons is not one of our modules)
": New feature" (no type)

Context

Keep a conventional & consistent format in our history.

Checklist

  • x ] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.

@ManonPolle ManonPolle added config 🛠 Related to configuration run 💨 labels Feb 22, 2023
@ManonPolle ManonPolle requested a review from a team as a code owner February 22, 2023 13:12
@ManonPolle ManonPolle mentioned this pull request Feb 22, 2023
Closed
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/336387c5-46cf-479a-a998-2d401827e9f8/artifact/b15a419871130334/p/05584c5bbf982aea2544f255d02243ed

Smoochibi
Smoochibi reviewed Feb 23, 2023
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/485e085c-9f87-4d37-8e7d-f16b02a1a94c/artifact/ef82b4dbd7a2b89a/p/b0c7f0a5582353798899716ef1b29f1d

@GerardPaligot GerardPaligot merged commit 041961c into Decathlon:main Feb 23, 2023
@ManonPolle ManonPolle added this to the 0.3.0 Version milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GerardPaligot GerardPaligot GerardPaligot approved these changes

@Smoochibi Smoochibi Smoochibi approved these changes

Assignees
No one assigned
Labels
config 🛠 Related to configuration
Projects
Decathlon Design System
Archived in project
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ManonPolle @dktbitrise @GerardPaligot @Smoochibi