Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sample): Add icons into Sample #114

Merged
merged 1 commit into from
Mar 3, 2023
Merged

feat(sample): Add icons into Sample #114

merged 1 commit into from
Mar 3, 2023

Conversation

ManonPolle
Copy link
Contributor

@ManonPolle ManonPolle commented Feb 22, 2023 •
edited
Loading

Changes description 🧑‍💻

Add icons screen into Sample app.
Add Asset screen into Sample app.
Add navigationIcon with a back button.

Context 🤔

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.

Screenshots 📸

image

image

image

image

Other info 👋

@ManonPolle ManonPolle added icons ✨ Related to icons build 🏗 labels Feb 22, 2023
@dktbitrise
Copy link

You can download the apk here :

@ManonPolle ManonPolle self-assigned this Feb 24, 2023
@ManonPolle ManonPolle marked this pull request as ready for review February 24, 2023 14:31
@ManonPolle ManonPolle requested a review from a team as a code owner February 24, 2023 14:31
@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/31bc874d-92e4-43b3-8401-7c1124c5005f/artifact/3ed4e80294ec7b48/p/9602e8fb2b4b355a3e192aab0dd086b1

@corentin-stamper corentin-stamper merged commit 0c71349 into Decathlon:main Mar 3, 2023
@ManonPolle ManonPolle added this to the 0.3.0 Version milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corentin-stamper corentin-stamper corentin-stamper approved these changes

@FDELAHA24 FDELAHA24 FDELAHA24 approved these changes

Assignees

@ManonPolle ManonPolle

Labels
icons ✨ Related to icons
Projects
Decathlon Design System
Archived in project
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ManonPolle @dktbitrise @corentin-stamper @FDELAHA24