Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(text-inputs): add paparazzi tests #123

Merged
merged 1 commit into from
Mar 30, 2023
Merged

chore(text-inputs): add paparazzi tests #123

merged 1 commit into from
Mar 30, 2023

Conversation

FDELAHA24
Copy link
Contributor

@FDELAHA24 FDELAHA24 commented Mar 10, 2023 •
edited by ManonPolle
Loading

Changes description 🧑‍💻

Add paparazzi tests

Context 🤔

Closes #97

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Other info 👋

@FDELAHA24 FDELAHA24 requested review from ManonPolle and a team as code owners March 10, 2023 16:01
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/4402fb34-e89a-47dc-be80-98882490433f/artifact/ce6f1efb9f664cf7/p/74150b7fe69db08cb8ffd146c508aea6

@lauthieb lauthieb added enhancement 🚀 New feature or request run 💨 labels Mar 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/d5bf38c8-ab54-498f-9fa5-b160858cd2c8/artifact/7a9cb04dd1be5065/p/38bfca322a72af5057c20522f13855bd

@ManonPolle ManonPolle requested a review from a team March 27, 2023 07:25
SimonLeclercq
SimonLeclercq reviewed Mar 30, 2023
View reviewed changes
Copy link

@SimonLeclercq SimonLeclercq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Design team have something to check? :)

@ManonPolle ManonPolle merged commit e697003 into Decathlon:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

@SimonLeclercq SimonLeclercq SimonLeclercq approved these changes

Assignees

@FDELAHA24 FDELAHA24

Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test(text-input): Add paparazzi tests
5 participants
@FDELAHA24 @dktbitrise @ManonPolle @SimonLeclercq @lauthieb