Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add important note #126

Merged
merged 4 commits into from
Mar 22, 2023
Merged

docs: add important note #126

merged 4 commits into from
Mar 22, 2023

Conversation

lauthieb
Copy link
Member

Changes description 🧑‍💻

Add the important note to indicate that this current version of Vitamin will no longer evolve and only accept bug fixes, new icons, and assets from now on. It also deletes the feature_or_improvement_request.md & new_component_request.md ISSUE_TEMPLATES.

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

@lauthieb lauthieb added documentation 📚 Improvements or additions to documentation run 💨 labels Mar 22, 2023
@lauthieb lauthieb requested review from ManonPolle and a team as code owners March 22, 2023 14:18
@lauthieb lauthieb self-assigned this Mar 22, 2023
@lauthieb lauthieb changed the title Docs/add important note docs: add important note Mar 22, 2023
ManonPolle
ManonPolle previously approved these changes Mar 22, 2023
View reviewed changes
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/a5bd7f78-d651-47e6-808a-99b3d8134b24/artifact/5ca8c72b3d7bdc09/p/0c698bfdd4d2cf8cc0369489fd9dc48c

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/cf0f632e-a2f4-4fbc-9b17-2d7b24ec958f/artifact/387e6d92d0131878/p/fb94c3a3ee06ed1d21192709fd1657d1

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/6ff9a8d5-1a89-4bad-8bdb-e9d5162e4a52/artifact/aae0a44e9c185acb/p/5ccf068fa8c9c56f28f496095766f551

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/2ed769d4-aa85-4f4d-8665-20871ead96a1/artifact/89549859f3ced1b9/p/cb724855c7b06d91140117aa28679d02

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/68d5978b-c518-47c3-944d-a1f1758324ba/artifact/fa0869bd310893a1/p/bd16af437d9e625b9cdb1c0a4829f491

@ManonPolle ManonPolle merged commit 3540a36 into main Mar 22, 2023
@ManonPolle ManonPolle deleted the docs/add-important-note branch March 22, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees

@lauthieb lauthieb

Labels
documentation 📚 Improvements or additions to documentation
Projects
Decathlon Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lauthieb @dktbitrise @ManonPolle