Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scaffolds): Create Vitamin scaffold component. #133

Merged
merged 1 commit into from
May 23, 2023

Conversation

GerardPaligot
Copy link
Contributor

Changes description πŸ§‘β€πŸ’»

Material design layout with Vitamin components.
Scaffold implements Material design visual layout structure and this component will use Vitamin
TopBar, Tabs, BottomBar and Floating Action Button according to models given in input.

Checklist βœ…

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots πŸ“Έ

com decathlon vitamin compose scaffolds_VitaminIconButtonsPrimaryTest_primary Primary,Dark com decathlon vitamin compose scaffolds_VitaminIconButtonsPrimaryTest_primary Primary,Light

@GerardPaligot GerardPaligot requested review from ManonPolle and a team as code owners April 13, 2023 14:05
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

@lauthieb lauthieb added the enhancement πŸš€ New feature or request label Apr 18, 2023
scaffolds/README.md Outdated Show resolved Hide resolved
scaffolds/README.md Outdated Show resolved Hide resolved
scaffolds/README.md Outdated Show resolved Hide resolved
scaffolds/README.md Outdated Show resolved Hide resolved
scaffolds/README.md Outdated Show resolved Hide resolved
scaffolds/README.md Outdated Show resolved Hide resolved
scaffolds/README.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

@ManonPolle ManonPolle merged commit b63cf7b into Decathlon:main May 23, 2023
@GerardPaligot GerardPaligot deleted the feat/scaffold branch May 30, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement πŸš€ New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants