Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add documentation_improvement.md issue template #145

Merged
merged 2 commits into from
May 12, 2023
Merged

chore: add documentation_improvement.md issue template #145

merged 2 commits into from
May 12, 2023

Conversation

lauthieb
Copy link
Member

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

@lauthieb lauthieb requested review from ManonPolle and a team as code owners May 10, 2023 15:08
@lauthieb lauthieb self-assigned this May 10, 2023
@lauthieb lauthieb added documentation 📚 Improvements or additions to documentation config 🛠 Related to configuration labels May 10, 2023
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/42cd2c0a-d2c0-46c6-a98d-e0aae2cccc90/artifact/a3540a90747427e0/p/d49cb06254e6c70448a3754d70aee0f7

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/1dec3864-8205-41d2-9996-af5cbd7850b5/artifact/c5505d892c0a80b6/p/0d2e60ecf43fdfb8ef272484d8922187

@ManonPolle ManonPolle merged commit e088aa3 into main May 12, 2023
@ManonPolle ManonPolle deleted the docs/issue-template branch May 12, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees

@lauthieb lauthieb

Labels
config 🛠 Related to configuration documentation 📚 Improvements or additions to documentation
Projects
Decathlon Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lauthieb @dktbitrise @ManonPolle