Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(buttons): Fix not centered radio button #149

Merged
merged 5 commits into from
May 25, 2023
Merged

feat(buttons): Fix not centered radio button #149

merged 5 commits into from
May 25, 2023

Conversation

adrienmu
Copy link
Contributor

@adrienmu adrienmu commented May 17, 2023 •
edited
Loading

Changes description 🧑‍💻

• Fix the position of the radiobutton

Context 🤔

Close #143

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Before
image

After
image

@adrienmu adrienmu requested review from ManonPolle and a team as code owners May 17, 2023 10:15
@adrienmu adrienmu marked this pull request as draft May 17, 2023 11:08
@adrienmu adrienmu marked this pull request as ready for review May 17, 2023 11:21
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/22168a18-dda9-46a1-ad29-bd9a3e015a90/artifact/b7a548f829a569ff/p/d0f779dc867cc692c3389e6a581c22f9

@adrienmu adrienmu changed the title feat(buttons): remove the minWidth of the parent view feat(buttons): Fix not centered radio button May 17, 2023
@adrienmu adrienmu requested a review from ManonPolle May 17, 2023 15:43
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/685eddf2-69c7-4c86-85b8-7439a59aa7d2/artifact/fa98b1683d490d4f/p/cd0df120a7d5ef8099f01604f4a116f7

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/00a413f3-47a8-4bff-86e4-1028a10ed569/artifact/d68baafedd0db346/p/f273c8dea9dd12e8cee8654d83883edd

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/5fff974b-a521-4eab-9472-404146cec6dd/artifact/b2fbf5530cede2db/p/f6876afd43616016bb312b68dfea8a98

@ManonPolle ManonPolle merged commit 3221854 into Decathlon:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RadioButton not centered
3 participants
@adrienmu @dktbitrise @ManonPolle