Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: request focus on search app bar #154

Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix: request focus on search app bar #154

merged 1 commit into from
Jun 22, 2023

Conversation

adrienbusin
Copy link
Contributor

Changes description 🧑‍💻

Add request focus on search app bar, can be deactivated with requestFocus boolean

Context 🤔

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Other info 👋

@adrienbusin adrienbusin requested review from ManonPolle and a team as code owners June 8, 2023 13:13
@adrienbusin adrienbusin force-pushed the fix/AppBars branch 4 times, most recently from cca2912 to 3e4a414 Compare June 8, 2023 14:16
ManonPolle
ManonPolle previously approved these changes Jun 20, 2023
View reviewed changes
@dktbitrise
Copy link

You can download the apk here :

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/177b9a57-9b16-4b49-8856-5d29d5f4d8e4/artifact/80ba92d2c1c80c89/p/f8e71a993d5353976fc33b94037bf16a

@ManonPolle ManonPolle merged commit 709762c into Decathlon:main Jun 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrienbusin @dktbitrise @ManonPolle