Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tabs): add paparazzi tests #164

Merged
merged 1 commit into from
Jul 17, 2023
Merged

chore(tabs): add paparazzi tests #164

merged 1 commit into from
Jul 17, 2023

Conversation

FDELAHA24
Copy link
Contributor

@FDELAHA24 FDELAHA24 commented Jul 7, 2023 •
edited
Loading

Changes description 🧑‍💻

Add paparazzi tests for tabs

Context 🤔

Closes #96

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Other info 👋

@FDELAHA24 FDELAHA24 self-assigned this Jul 7, 2023
@FDELAHA24 FDELAHA24 requested a review from a team as a code owner July 7, 2023 16:01
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/bc08fbf3-94de-4c44-a75c-3c76b8897872/artifact/082b7f83ce04ef53/p/01984fdb970bb0efd02b2c595afd4a1c

ManonPolle
ManonPolle previously approved these changes Jul 13, 2023
View reviewed changes
@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/808e7afa-a138-42bc-b13c-8e1fb87fecf7/artifact/2e0f5c318d4f7ed1/p/5780eebca18895767fa2c560eb9f0183

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/1e06a445-18d3-4c03-ab5b-f3ceaff78751/artifact/d975043c775c0fd2/p/2bddd96d4425caa428a1e32d29e9dd7a

@ManonPolle ManonPolle merged commit 4d95fc9 into Decathlon:main Jul 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees

@FDELAHA24 FDELAHA24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test(tab): Add paparazzi tests
3 participants
@FDELAHA24 @dktbitrise @ManonPolle