Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-inputs): Character counter position #165

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix(text-inputs): Character counter position #165

merged 1 commit into from
Aug 4, 2023

Conversation

apauchet
Copy link
Contributor

@apauchet apauchet commented Jul 21, 2023 •
edited
Loading

Changes description 🧑‍💻

Fix issue about character counter position in cas of null helperText
Add textInput sample to check the fix

Context 🤔

Closes Decathlon/vitamin-android#183

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Screenshot_20230721_151620

Other info 👋

@apauchet apauchet requested review from ManonPolle and a team as code owners July 21, 2023 13:16
@apauchet apauchet force-pushed the fix/character_counter_position branch from ba5840b to a019d51 Compare July 21, 2023 13:17
@apauchet apauchet mentioned this pull request Jul 21, 2023
Closed
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/15c6893b-9eed-4337-b7f9-336f05dda659/artifact/9ec6148419c85107/p/e2e14cf57ced1f610b0df5bb05e3ee4e

FDELAHA24
FDELAHA24 suggested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@FDELAHA24 FDELAHA24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add the case (counter wihtout helper text) into VitaminTextInputsPrimaryTest and regenerate the snapshot ?

@apauchet apauchet force-pushed the fix/character_counter_position branch 5 times, most recently from 38f9a8b to e7a8fab Compare August 4, 2023 14:47
@dktbitrise
Copy link

You can download the apk here :

@apauchet apauchet force-pushed the fix/character_counter_position branch from e7a8fab to 7bebcee Compare August 4, 2023 15:24
@apauchet apauchet force-pushed the fix/character_counter_position branch from 7bebcee to 48a08d8 Compare August 4, 2023 15:27
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.19) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/5ee41acd-6ff0-4693-bfa1-d2dcfa8777cd/artifact/bb8371037c9a5380/p/e7f25bffa3c41ce774fd6572971b2b05

@ManonPolle ManonPolle merged commit 0da11ff into Decathlon:main Aug 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

@FDELAHA24 FDELAHA24 FDELAHA24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Decathlon Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Text input counter on Android
4 participants
@apauchet @dktbitrise @ManonPolle @FDELAHA24