Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Chip component with action, filter & input variants #17

Merged
merged 1 commit into from
Feb 3, 2023
Merged

feat: add Chip component with action, filter & input variants #17

merged 1 commit into from
Feb 3, 2023

Conversation

ManonPolle
Copy link
Contributor

@ManonPolle ManonPolle commented Jun 3, 2022 •
edited
Loading

Changes description 🧑‍💻

Context 🤔

Closes #4

Checklist ✅

  • I have reviewed the submitted code
  • I have tested on a phone device/emulator
  • I have tested on a tablet device/emulator
  • I have tested on a kiosk device/emulator
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

image

image

image

image

Phone

Other info 👋

@CLAassistant
Copy link

CLAassistant commented Jun 3, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

FDELAHA24 pushed a commit to FDELAHA24/vitamin-compose-public that referenced this pull request Jun 10, 2022
@adrienbusin
feat: Create Radio buttons component (Decathlon#17)
e5bfb7a
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/16439ab8-ce42-4261-96ee-a79b3e926ed1/artifact/802b7b9504679cb0/p/a03e4c264f4b6d7983e682ae6a5a8fc6

@ManonPolle ManonPolle changed the title WIP feat: (CHIP) Medium Action Chip feat: Add Chip component with action, filter & input variants Jun 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/896cd676-362d-4dbb-b874-cf064081b192/artifact/0e1621d90a1ae1bf/p/c40c7daf38790f79e8b76f755dfd4d9b

FDELAHA24
FDELAHA24 suggested changes Jun 24, 2022
View reviewed changes
sample/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
chips/gradle.properties Outdated Show resolved Hide resolved
sample/src/main/java/com/decathlon/compose/sample/screens/Chips.kt Outdated Show resolved Hide resolved
chips/README.md Outdated Show resolved Hide resolved
chips/src/main/java/com/decathlon/vitamin/compose/chips/VitaminChipRipples.kt Outdated Show resolved Hide resolved
chips/src/main/java/com/decathlon/vitamin/compose/chips/VitaminChips.kt Outdated Show resolved Hide resolved
chips/src/main/java/com/decathlon/vitamin/compose/chips/VitaminChipButtons.kt Outdated Show resolved Hide resolved
@SimonLeclercq
Copy link

hey @ManonPolle,
regarding the input variant, let's close the chip with a tap on the whole component (not only the close-icon).
Have some doubt about ripple-color, it looks darker than in figma implementation.

@ManonPolle ManonPolle force-pushed the feat/chip branch 4 times, most recently from ce092f1 to 6c4e693 Compare August 12, 2022 16:00
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/4a3992bd-159e-478b-8658-6e2ad03ec991/artifact/483e9f2b31ef8c44/p/d9372d26c7ab6107656888af9cdba3d0

FDELAHA24
FDELAHA24 previously approved these changes Aug 19, 2022
View reviewed changes
@lauthieb lauthieb changed the title feat: Add Chip component with action, filter & input variants feat: add Chip component with action, filter & input variants Oct 27, 2022
@lauthieb lauthieb added the enhancement 🚀 New feature or request label Oct 27, 2022
GerardPaligot
GerardPaligot requested changes Nov 16, 2022
View reviewed changes
chips/README.md Outdated Show resolved Hide resolved
chips/README.md Outdated Show resolved Hide resolved
chips/README.md Outdated Show resolved Hide resolved
chips/README.md Outdated Show resolved Hide resolved
chips/src/main/java/com/decathlon/vitamin/compose/chips/VitaminChipButtons.kt Show resolved Hide resolved
chips/src/main/java/com/decathlon/vitamin/compose/chips/VitaminChips.kt Outdated Show resolved Hide resolved
chips/src/main/java/com/decathlon/vitamin/compose/chips/VitaminChips.kt Outdated Show resolved Hide resolved
chips/src/main/java/com/decathlon/vitamin/compose/chips/VitaminChips.kt Outdated Show resolved Hide resolved
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/c26aaa3c-ff2d-43ac-99a9-981139c424fc/artifact/0b4edc4dbc2c1707/p/f81e8e80a432d3ef5ef4496c8caa6432

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/21a6f5e4-d13b-488d-8307-ae1bdd5446e7/artifact/b6c70529c0e99b40/p/43e561c9b794e56fdae22cd59f7319c0

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/77fbd498-377f-4195-bfc4-ec44233f4f2f/artifact/5e064d3ce6f2fb90/p/a164a75496d7992b8fb69de1a5f8f82c

GerardPaligot
GerardPaligot requested changes Jan 19, 2023
View reviewed changes
chips/README.md Outdated Show resolved Hide resolved
chips/src/main/java/com/decathlon/vitamin/compose/chips/VtmnChipColors.kt Outdated Show resolved Hide resolved
chips/src/main/java/com/decathlon/vitamin/compose/chips/VtmnChipColors.kt Outdated Show resolved Hide resolved
chips/README.md Show resolved Hide resolved
chips/README.md Show resolved Hide resolved
chips/README.md Outdated Show resolved Hide resolved
chips/src/main/java/com/decathlon/vitamin/compose/chips/VitaminChipButtons.kt Outdated Show resolved Hide resolved
chips/src/main/java/com/decathlon/vitamin/compose/chips/VitaminChipButtons.kt Outdated Show resolved Hide resolved
@ManonPolle ManonPolle requested a review from a team as a code owner January 20, 2023 10:09
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/29e3f05b-245d-4b62-8761-944f81defc51/artifact/9d63c32b4aa96860/p/72d55032fb07f4bb1b76ee8bb5f68664

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/b19ccedb-e3ff-46e4-af08-1bf0decc7ce9/artifact/97fb46ff1e313a28/p/f29cb323efe68da7122c1e79154014ab

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/fe879115-c8dd-4b69-8fae-7af638c1f8b3/artifact/589c5e1724fc9736/p/11a41e3d3198eb8c3cf4694062d0f6dc

GerardPaligot
GerardPaligot previously approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@GerardPaligot GerardPaligot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats!

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/9897f415-5ff7-4084-a0ed-3e7f88886652/artifact/c0e85fea3fc21756/p/27f092e56f2741e46a25137eaf464173

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/dd02e41a-feed-4342-8c1d-9b4281d48453/artifact/b3c7a9b4f9c1762e/p/d1d18a5fa1f18f8f8f0177dc413fd8c4

@ManonPolle ManonPolle requested a review from a team January 30, 2023 08:47
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/05917196-06de-498a-a9e0-1628c7448250/artifact/739ca8b609be9cff/p/10ae89598e76ea9781af8fa9eab8d8c7

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/ed86c0a2-55b4-40d1-8a89-c27f96daa237/artifact/a70eff0286294d8c/p/7fb50fba8539d5b43758c6451ff507ca

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@GerardPaligot GerardPaligot merged commit 66b5640 into Decathlon:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GerardPaligot GerardPaligot GerardPaligot approved these changes

@SimonLeclercq SimonLeclercq SimonLeclercq approved these changes

@FDELAHA24 FDELAHA24 FDELAHA24 left review comments

@lauthieb lauthieb Awaiting requested review from lauthieb

@rcarondecathlon rcarondecathlon Awaiting requested review from rcarondecathlon

@corentin-stamper corentin-stamper Awaiting requested review from corentin-stamper

@adrienbusin adrienbusin Awaiting requested review from adrienbusin

Assignees

@ManonPolle ManonPolle

Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add Chip Component
7 participants
@ManonPolle @CLAassistant @dktbitrise @SimonLeclercq @GerardPaligot @FDELAHA24 @lauthieb