Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-inputs): Improve helper text allocation on TextInput #179

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix(text-inputs): Improve helper text allocation on TextInput #179

merged 1 commit into from
Oct 11, 2023

Conversation

ManonPolle
Copy link
Contributor

Changes description 🧑‍💻

Context 🤔

Closes #177

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.

Screenshots 📸

image

@ManonPolle ManonPolle requested a review from a team as a code owner October 11, 2023 10:02
@dktbitrise
Copy link

You can download the apk here :

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/fc718929-5d19-4448-a39c-e52c956ec8e1/artifact/f928c3c0508c3a52/p/ef5546f9983cd827897ec6b45b60bc3d

FDELAHA24
FDELAHA24 reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@FDELAHA24 FDELAHA24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a paparazzi case with a long helper text ?

...puts/text-inputs/src/main/java/com/decathlon/vitamin/compose/textinputs/VitaminTextInputs.kt Show resolved Hide resolved
@ManonPolle ManonPolle merged commit e6645ac into Decathlon:main Oct 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FDELAHA24 FDELAHA24 FDELAHA24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat (text-inputs): better space allocation between helpertext and counter
3 participants
@ManonPolle @dktbitrise @FDELAHA24