Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Fab): add fab and fab extended components #60

Merged
merged 1 commit into from
Jan 18, 2023
Merged

feat(Fab): add fab and fab extended components #60

merged 1 commit into from
Jan 18, 2023

Conversation

FDELAHA24
Copy link
Contributor

@FDELAHA24 FDELAHA24 commented Dec 23, 2022 •
edited
Loading

Changes description 🧑‍💻

Adds fab and fab extended components

Context 🤔

#50

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Screenshot_20230113_164546

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/da66b88f-3bd9-4ec6-82c7-55950d4ed5af/artifact/e253dbb232e5f681/p/e54030f6e67eb27a1bd02eec20be1540

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/dac2efe8-31b5-49f2-a255-62c76b2139ca/artifact/707474bad01910d6/p/37a474867562872d845dd2114c419560

ManonPolle
ManonPolle previously approved these changes Dec 28, 2022
View reviewed changes
@FDELAHA24 FDELAHA24 self-assigned this Dec 29, 2022
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/0d5866dc-f7c7-40d8-a86d-97ee5632c3c5/artifact/474ea81a0c71db93/p/738a08d436cee87f1b994a9ed51bdfc2

GerardPaligot
GerardPaligot requested changes Dec 30, 2022
View reviewed changes
fabs/README.txt Outdated Show resolved Hide resolved
fabs/README.txt Outdated Show resolved Hide resolved
fabs/src/main/java/com/decathlon/vitamin/compose/fabs/VitaminFabs.kt Outdated Show resolved Hide resolved
fabs/src/main/java/com/decathlon/vitamin/compose/fabs/VitaminFabs.kt Outdated Show resolved Hide resolved
fabs/src/main/java/com/decathlon/vitamin/compose/fabs/VitaminFabsExtended.kt Outdated Show resolved Hide resolved
fabs/src/main/java/com/decathlon/vitamin/compose/fabs/VitaminFabsExtended.kt Outdated Show resolved Hide resolved
@FDELAHA24 FDELAHA24 force-pushed the feat/fab_button branch 2 times, most recently from 4c12367 to 4b51cc9 Compare December 30, 2022 15:50
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/cc4479da-430d-44fe-b3a0-f7cee439cd69/artifact/ca4fefcd66696ee4/p/b7d4e73e3dc2a0ebb99d92174d67d5bd

GerardPaligot
GerardPaligot previously approved these changes Dec 30, 2022
View reviewed changes
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/7bea9741-4c20-4ba2-8b58-78ee88a8edc6/artifact/d0b4e345c25c21f4/p/4f22180a0710c39be5c9d8016b31bc82

@lauthieb lauthieb linked an issue Jan 6, 2023 that may be closed by this pull request
feat: add Fab Component #50
Closed
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/5969a3b1-5291-4369-9a00-5848de455d84/artifact/303466f6d1e16005/p/add1a60b90f4560b2ee3a908386bb3ff

@lauthieb lauthieb added enhancement 🚀 New feature or request build 🏗 and removed design request 🙌 labels Jan 9, 2023
@ManonPolle ManonPolle requested a review from a team January 11, 2023 10:07
@FDELAHA24 FDELAHA24 requested review from a team as code owners January 13, 2023 13:13
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/d5322486-4b50-4381-9fd4-a7e8ce629b9c/artifact/0e62c445827984ae/p/949898cd1665f3d9703fdf3e0249c554

@FDELAHA24 FDELAHA24 mentioned this pull request Jan 13, 2023
Closed
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/6bf7289f-2c51-4a9f-9879-d95f83fde07c/artifact/de5648419260fc8a/p/2d1d187a9b1e3b4d641250e4dd61dc4a

@ManonPolle ManonPolle requested review from a team and removed request for a team January 16, 2023 08:04
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/c433ad1b-7647-4bfe-809a-b5c689e5a556/artifact/27628c0612ddf4f9/p/e38b2c7e21e66c93510ca7be464f488b

@SimonLeclercq
Copy link

@FDELAHA24 some issues on hover style which is not accessible on Compose implementation. I guess native ripple is recquired here 🤔. @ManonPolle takes over on this topic!

ManonPolle
ManonPolle previously approved these changes Jan 18, 2023
View reviewed changes
@dktbitrise
Copy link

You can download the apk here :

@dktbitrise
Copy link

You can download the apk here :

@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/604a9743-957f-450a-b06f-c6d8dffc2c8f/artifact/b9e3662649bd7af6/p/d14be86cd3444dec7f6f7cd42a746ebd

@ManonPolle ManonPolle merged commit 9b34c17 into Decathlon:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

@SimonLeclercq SimonLeclercq SimonLeclercq approved these changes

@GerardPaligot GerardPaligot GerardPaligot left review comments

@lauthieb lauthieb Awaiting requested review from lauthieb

@adrienbusin adrienbusin Awaiting requested review from adrienbusin

@corentin-stamper corentin-stamper Awaiting requested review from corentin-stamper

@rcarondecathlon rcarondecathlon Awaiting requested review from rcarondecathlon

Assignees

@FDELAHA24 FDELAHA24

Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add Fab Component
7 participants
@FDELAHA24 @dktbitrise @SimonLeclercq @GerardPaligot @adrienbusin @ManonPolle @lauthieb