Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade libraries versions. #62

Merged
merged 3 commits into from
Dec 30, 2022
Merged

chore: Upgrade libraries versions. #62

merged 3 commits into from
Dec 30, 2022

Conversation

corentin-stamper
Copy link
Contributor

Changes description 🧑‍💻

library old version new version
Android Gradle plugin 7.2.1 7.3.1
Kotlin Gradle plugin 1.6.21 1.7.0
sonarqube 3.3 3.5.0.2730
ktlint 10.2.0 11.0.0
vitamin-android 0.4.0-beta01 0.4.0
refreshVersions 0.40.2 0.51.0
customview-poolingcontainer 1.0.0-beta02 1.0.0
compose 1.2.0-rc01 1.2.0
accompanist 0.24.11-rc 0.25.0
espresso 3.4.0 3.5.0
junit 1.1.3 1.1.4

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review with a core team designer.

@corentin-stamper corentin-stamper self-assigned this Dec 30, 2022
@corentin-stamper corentin-stamper added the config 🛠 Related to configuration label Dec 30, 2022
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/e5d6caf8-7ad4-4891-adac-7fc6b926dabb/artifact/9b3f7e935b2a01cd/p/afd790205a7f1f80ae994cb7ff940d11

corentin-stamper
corentin-stamper commented Dec 30, 2022
View reviewed changes
settings.gradle.kts Outdated Show resolved Hide resolved
@corentin-stamper corentin-stamper marked this pull request as draft December 30, 2022 15:35
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/3424910f-4066-41c4-ba9f-4e531047407c/artifact/3759476721d07b85/p/722ebaed829d39f6b6f813159e1f2b34

@corentin-stamper corentin-stamper marked this pull request as ready for review December 30, 2022 16:10
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/bb9034f3-1f12-470f-bd70-130ccb2effb8/artifact/27be1608bd92b660/p/1f8601cd99ecae6df1de4574d8b37e79

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/aeec70ac-55e1-439d-9f05-deeb1949e317/artifact/a492e1387c8eba4e/p/a665c48b85f86c633517d962271e7df9

@corentin-stamper corentin-stamper merged commit c66fce0 into Decathlon:main Dec 30, 2022
@corentin-stamper corentin-stamper deleted the chore/versions-1 branch December 30, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GerardPaligot GerardPaligot GerardPaligot approved these changes

@lauthieb lauthieb Awaiting requested review from lauthieb

@adrienbusin adrienbusin Awaiting requested review from adrienbusin

@ManonPolle ManonPolle Awaiting requested review from ManonPolle ManonPolle is a code owner

@FDELAHA24 FDELAHA24 Awaiting requested review from FDELAHA24

@rcarondecathlon rcarondecathlon Awaiting requested review from rcarondecathlon

Assignees

@corentin-stamper corentin-stamper

Labels
config 🛠 Related to configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corentin-stamper @dktbitrise @GerardPaligot