Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create small variant size for tags #64

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Create small variant size for tags #64

merged 2 commits into from
Jan 18, 2023

Conversation

GerardPaligot
Copy link
Contributor

@GerardPaligot GerardPaligot commented Dec 30, 2022 •
edited by lauthieb
Loading

Changes description 🧑‍💻

  • Create small variant size for tags
  • Create snapshot tests with Paparazzi

Context 🤔

Closes #59

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

com decathlon vitamin compose tags_VitaminTagsTest_small Default,Light

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/439bfd42-faa4-41b3-8a46-df72f711ddb4/artifact/68f727568670e890/p/f009c34d511a6806e087f29b1b495b9c

@lauthieb lauthieb added enhancement 🚀 New feature or request run 💨 labels Jan 9, 2023
@ManonPolle ManonPolle requested a review from a team as a code owner January 18, 2023 08:55
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/baf85701-61c7-42cd-b81f-ccc653be1671/artifact/73cbc3225b03ba99/p/e08748611c2d2090a9584a2ea4023c73

@ManonPolle ManonPolle merged commit 0dd9529 into Decathlon:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corentin-stamper corentin-stamper corentin-stamper approved these changes

@ManonPolle ManonPolle ManonPolle approved these changes

@lauthieb lauthieb Awaiting requested review from lauthieb

@adrienbusin adrienbusin Awaiting requested review from adrienbusin

@FDELAHA24 FDELAHA24 Awaiting requested review from FDELAHA24

@rcarondecathlon rcarondecathlon Awaiting requested review from rcarondecathlon

Assignees
No one assigned
Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(tag): Add a small size for Tag component
5 participants
@GerardPaligot @dktbitrise @corentin-stamper @ManonPolle @lauthieb