Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Button): add icon button contentDescription #65

Merged
merged 1 commit into from
Dec 30, 2022
Merged

fix(Button): add icon button contentDescription #65

merged 1 commit into from
Dec 30, 2022

Conversation

FDELAHA24
Copy link
Contributor

@FDELAHA24 FDELAHA24 commented Dec 30, 2022 •
edited
Loading

Changes description 🧑‍💻

Add the missing content description for the icon button

Context 🤔

#63

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review with a core team designer.

Screenshots 📸

Screenshot_20221230_170922

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/44f50d4a-f826-4961-89f8-c49b21331f07/artifact/447ce1ad85f0d3ec/p/244d2630c0b51132b3079166f863501c

@GerardPaligot GerardPaligot merged commit 6aca01a into Decathlon:main Dec 30, 2022
@GerardPaligot GerardPaligot deleted the fix/icon_button_content_description branch December 30, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GerardPaligot GerardPaligot GerardPaligot approved these changes

@lauthieb lauthieb Awaiting requested review from lauthieb

@adrienbusin adrienbusin Awaiting requested review from adrienbusin

@ManonPolle ManonPolle Awaiting requested review from ManonPolle ManonPolle is a code owner

@rcarondecathlon rcarondecathlon Awaiting requested review from rcarondecathlon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FDELAHA24 @dktbitrise @GerardPaligot