Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Progress): Add extra small size #67

Merged
merged 1 commit into from
Jan 18, 2023
Merged

feat(Progress): Add extra small size #67

merged 1 commit into from
Jan 18, 2023

Conversation

FDELAHA24
Copy link
Contributor

@FDELAHA24 FDELAHA24 commented Jan 6, 2023 •
edited by lauthieb
Loading

Changes description 🧑‍💻

Add extra small size for progress component

Context 🤔

#52

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Screenshot_20230106_154448

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/cd1b99af-656c-4db4-abe7-6d971878a700/artifact/8ca16865d9774c27/p/650115d7b9267ca07c08bc86431b7682

@corentin-stamper
Copy link
Contributor

@SimonLeclercq - Design validation needed

@FDELAHA24 FDELAHA24 force-pushed the feat/add_progress_extra_small_size branch from 89869c7 to 878e272 Compare January 6, 2023 16:56
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/5d6b04c8-ebb6-431c-ad65-e83368b46c79/artifact/5ac0464013767e0c/p/6dc05d7d6f59431e7b893d86a9bf3009

@lauthieb lauthieb added enhancement 🚀 New feature or request run 💨 labels Jan 9, 2023
@lauthieb lauthieb linked an issue Jan 9, 2023 that may be closed by this pull request
feat: add a small size for Progressbar component #52
Closed
@ManonPolle ManonPolle requested a review from a team January 11, 2023 10:08
@FDELAHA24 FDELAHA24 force-pushed the feat/add_progress_extra_small_size branch from 878e272 to 5ebf439 Compare January 13, 2023 13:12
@FDELAHA24 FDELAHA24 requested review from a team as code owners January 13, 2023 13:12
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/811c4736-d2ad-4010-b5a7-c04de675cb88/artifact/bb2a66e5838b1c8a/p/69e82dcd1dd858c2b29e30a6202c0777

@FDELAHA24 FDELAHA24 self-assigned this Jan 13, 2023
@SimonLeclercq
Copy link

👍

@ManonPolle ManonPolle force-pushed the feat/add_progress_extra_small_size branch from 5ebf439 to 3151102 Compare January 17, 2023 14:05
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/95ea00a0-77ff-4035-8bb5-a30c8dfda2eb/artifact/cb5306dc48819004/p/20ecafb17846cea2b73baec374d8812e

@ManonPolle ManonPolle merged commit 6f6bc61 into Decathlon:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corentin-stamper corentin-stamper corentin-stamper approved these changes

@SimonLeclercq SimonLeclercq SimonLeclercq approved these changes

@lauthieb lauthieb Awaiting requested review from lauthieb

@GerardPaligot GerardPaligot Awaiting requested review from GerardPaligot

@adrienbusin adrienbusin Awaiting requested review from adrienbusin

@ManonPolle ManonPolle Awaiting requested review from ManonPolle ManonPolle is a code owner

@rcarondecathlon rcarondecathlon Awaiting requested review from rcarondecathlon

Assignees

@FDELAHA24 FDELAHA24

Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add a small size for Progressbar component
6 participants
@FDELAHA24 @dktbitrise @corentin-stamper @SimonLeclercq @lauthieb @ManonPolle